fix(language-service): Instantiate MetadataResolver once #32145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: language-service
kyliau
force-pushed
the
typescript_host
branch
from
e186f0d
to
f11c93b
Compare
ayazhafiz
reviewed
Aug 15, 2019
kyliau
force-pushed
the
typescript_host
branch
from
f11c93b
to
642a190
Compare
ayazhafiz
approved these changes
Aug 15, 2019
AndrewKushnir
added
the
action: cleanup
|
@kyliau could you plz rebase this PR on top of master branch and resolve the conflict? Thank you. |
Instead of destroying and recreating MetadataResolver every time the program changes, create one instance and reuse it throughout the lifetime of the language service. Since Angular StaticSymbols are invalidated when program gets out-of-date, this should be safe. This should make the language service more more performant.
kyliau
force-pushed
the
typescript_host
branch
from
642a190
to
b9e2365
Compare
kyliau
removed
the
action: cleanup
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
Instead of destroying and recreating MetadataResolver every time the program changes, create one instance and reuse it throughout the lifetime of the language service. Since Angular StaticSymbols are invalidated when program gets out-of-date, this should be safe. This should make the language service more more performant. PR Close angular#32145
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of destroying and recreating MetadataResolver every time the
program changes, create one instance and reuse it throughout the
lifetime of the language service.
Since Angular StaticSymbols are invalidated when program gets
out-of-date, this should be safe.
This should make the language service much more performant.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information